Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start playing the daily challenge track during the intro (and automatically download) #29347

Merged
merged 8 commits into from
Aug 12, 2024

Conversation

peppy
Copy link
Member

@peppy peppy commented Aug 8, 2024

@pull-request-size pull-request-size bot added size/M and removed size/XL labels Aug 8, 2024
@smoogipoo smoogipoo requested a review from bdach August 8, 2024 07:58
@@ -503,17 +494,30 @@ public override bool OnExiting(ScreenExitEvent e)
return base.OnExiting(e);
}

private void applyLoopingToTrack()
public static void TrySetDailyChallengeBeatmap(OsuScreen screen, BeatmapManager beatmaps, RulesetStore rulesets, MusicController music, PlaylistItem item)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight teeth pain at this method's public-static-dependency-accepting shape but I guess it's localised so probably fine. Likely better than weird inheritance anyhow

@bdach bdach merged commit 7b51ec8 into ppy:master Aug 12, 2024
10 of 13 checks passed
@peppy peppy deleted the daily-challenge-intro-audio-auto-download branch August 13, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants